sourcegraph / src-cli

Sourcegraph CLI
https://sourcegraph.com
Apache License 2.0
267 stars 57 forks source link

Turn off race detection for upload test #1082

Closed varungandhi-src closed 1 month ago

varungandhi-src commented 1 month ago

Having the tests be red on main is confusing. While we wait for https://github.com/stretchr/testify/pull/1598 to land, I think it's best to turn off the bad test when running with the race detector. So this PR moves the test to a different file which is only compiled with go:build !race.

I couldn't quite figure out how to run the single test without race detection while running others with race detection, so I've temporarily added two test commands in the go-ci.yml file.

Test plan

Covered by existing tests