scan: skip (don't make fatal) if go getting or importing a dep fails

sourcegraph / srclib-go

Go toolchain for srclib

https://sourcegraph.com/sourcegraph/srclib-go

MIT License

29 stars 13 forks source link

scan: skip (don't make fatal) if go getting or importing a dep fails #102

Closed sqs closed 8 years ago

sqs commented 8 years ago

This step can fail when a dependency package has been moved or its host is down. Failures here will degrade the analysis, but they should not be fatal, or else the build success is very sensitive to external dependencies.

Fixes the camlistore build on Sourcegraph.

dmitshur commented 8 years ago

LGTM.

dmitshur commented 8 years ago

Minor comment. To reduce the chance of this behavior regressing, I'd suggesting adding a comment to the prepareDependencies func documenting its behavior. Namely, that it does a best effort attempt to prepare dependencies and skips the ones that fail.