search

sourcegraph / srclib-go

Go toolchain for srclib
https://sourcegraph.com/sourcegraph/srclib-go
MIT License
29 stars 13 forks source link

Replace loader #98

Closed neelance closed 8 years ago

neelance commented 8 years ago

This allows to actually use .a archive files and to process packages individually.

beyang commented 8 years ago

Has this been tested against the standard library, the sourcegraph repository, and other large Go repositories?

keegancsmith commented 8 years ago

Has this been tested against the standard library, the sourcegraph repository, and other large Go repositories?

We should just get CI/testsuite to do that. A submodule pointing to those repos seems decent.

keegancsmith commented 8 years ago

LGTM

Only change that would be nice is that we aren't deprecating Srcfile, but in fact removing support for it. That may just be me being a bit pedantic though.

keegancsmith commented 8 years ago

Oh yeah, also would be good to test this out on important repos before getting this out into production sourcegraph.