Open sunnyrjuneja opened 10 years ago
Ah, I hadn't even foreseen installing it as a gem, only running it via src
.
1) Yeah, separating the YARD fork sounds good. I had put them together because I thought we'd be changing the YARD fork and the srclib-ruby code in unison a lot, but that has not occurred. 2) I think if you change this line:
spec.files += Dir.glob("{.bin,lib,spec}/**/*.rb") + Dir.glob("{yard/bin,yard/lib}/**/*")
to
spec.files += Dir.glob("{.bin,lib,spec}/**/*.rb") + Dir.glob("{yard/bin,yard/lib}/**/*.rb")
it won't read in the .gitignore, .rspec, etc., files, which should fix the errors you're seeing.
@sqs wouldn't that ignore the binary since it doesn't have an extension (yard/yardoc/yri)? maybe
spec.files += Dir.glob("{.bin,lib,spec}/**/*.rb") + Dir.glob("yard/lib/**/*.rb") + Dir.glob('yard/bin/*')
Oh yeah, you are right.
I installed srclib-ruby from source using
gem build
andgem install
. I've been experimenting with the CLI and it seems to be working fine except for graph.The problem is when srcgraph-lib is installed, it only includes
srcgraph/lib
. A simple fix would be to change the following lines in the gemspec (I think it might be easier to package yard-fork as its own gem and add it as a runtime dependency).However, this returns new errors in the warning: