search

sourcegraph / srclib-ruby

https://sourcegraph.com/sourcegraph/srclib-ruby
9 stars 9 forks source link

Refactor scanner #6

Open njwhite opened 10 years ago

njwhite commented 10 years ago

1) use information from the Gem::Specification to find ruby scripts instead of scraping the gem's directory

2) Create units for Gem dependencies where possible.

sqs commented 10 years ago

Thanks for the PR!

We added the functionality that finds stray Ruby scripts because there are lots of repositories that aren't gems that you'd still like to use with srclib. It looks like this change would only pull in Ruby script files that are mentioned in the gemspec, right?

/cc @rameshvarun

njwhite commented 10 years ago

@sqs I've re-added that functionality, but made each non-gem script a separate unit as in the general case they'd be unrelated to each other? Thanks -

njwhite commented 10 years ago

@sqs I think the build failure's a bug in a different component. I can reproduce it locally; src make gives errors like the one in Travis:

CONFIG PROPERTIES (0)

no rule to make target "/home/travis/build/sourcegraph/srclib-ruby/testdata/case/ruby-sample-0/lib/cases/top_const.rb"

make: *** [test] Error 1

It seems make can't see the ruby files - ls confirms they're definitely there. However, src make --print >x && make -f x works fine.

sqs commented 10 years ago

Got it. I will look into this later today. Thanks again for submitting this PR.