Handling UTF-8 BOM and adjusting srclib-csharp offsets

sourcegraph / srclib

srclib is a polyglot code analysis library, built for hackability. It consists of language analysis toolchains (currently for Go and Java, with Python, JavaScript, and Ruby in beta) with a common output format, and a CLI tool for running the analysis.

https://srclib.org

Other

942 stars 62 forks source link

Handling UTF-8 BOM and adjusting srclib-csharp offsets #241

Closed alexsaveliev closed 8 years ago

alexsaveliev commented 8 years ago

Bumping version of github.com/sqs/fileset to include recent changes related to UTF-8 BOM support
srclib-csharp emits defs and refs character-based offsets so they need to be converted to byte ones.

dmitshur commented 8 years ago

Bumping version of github.com/sqs/fileset to include recent changes related to UTF-8 BOM support

That part doesn't seem right. Are you sure it's done correctly?

I'm seeing that only the Godeps/Godeps.json file has changed, but none of the actual vendored dependency code has changed.

Given the diff in commits, I'd expect to see this change:

https://github.com/sqs/fileset/compare/4317e899aa9438ba7603a6e322389571cb3ffdff...af79d58d268e6fb30711babccd37156c95fd5aaf

(Maybe not including the _test.go file.)

dmitshur commented 8 years ago

Ah, I see that this repository uses a non-copy godep mode. It only has the Godeps.json file, but doesn't copy/vendor the actual dependencies inside the repo. So the change above is valid.

https://github.com/sourcegraph/srclib/tree/master/Godeps

Sorry for the noise, and thanks for pointing it out @alexsaveliev!