sourcegraph / srclib

srclib is a polyglot code analysis library, built for hackability. It consists of language analysis toolchains (currently for Go and Java, with Python, JavaScript, and Ruby in beta) with a common output format, and a CLI tool for running the analysis.
https://srclib.org
Other
942 stars 62 forks source link

Coverage command #246

Closed jpoler closed 8 years ago

jpoler commented 8 years ago

@keegancsmith do you mind giving this a sanity check?

keegancsmith commented 8 years ago

A few suggestions. Once addressed, lets maybe experiment with this on Sourcegraph before merging it into master.

FYI I think it is fine that this is super go specific right now and lives inside of srclib (rather than srclib-go). As we expand this to other langs, we can move code round into a slightly more complicated architecture.

jpoler commented 8 years ago

@keegancsmith Do you mind looking over this one more time? I've addressed everything but the aggregate stats. We can come back to that.

keegancsmith commented 8 years ago

@jpoler one inline comment. Otherwise LGTM