Closed jpoler closed 8 years ago
A few suggestions. Once addressed, lets maybe experiment with this on Sourcegraph before merging it into master.
FYI I think it is fine that this is super go specific right now and lives inside of srclib (rather than srclib-go
). As we expand this to other langs, we can move code round into a slightly more complicated architecture.
@keegancsmith Do you mind looking over this one more time? I've addressed everything but the aggregate stats. We can come back to that.
@jpoler one inline comment. Otherwise LGTM
@keegancsmith do you mind giving this a sanity check?