search

sourcegraph / srclib

srclib is a polyglot code analysis library, built for hackability. It consists of language analysis toolchains (currently for Go and Java, with Python, JavaScript, and Ruby in beta) with a common output format, and a CLI tool for running the analysis.
https://srclib.org
Other
942 stars 62 forks source link

Inconsistent versions of gogo/protobuf/...? #294

Closed alexsaveliev closed 8 years ago

alexsaveliev commented 8 years ago 
grep gogo -A 1 vendor/vendor.json
                        "path": "github.com/gogo/protobuf/jsonpb",
                        "revision": "128ef922449da3dbb6c5d942856877a1a7235fef",
--
                        "path": "github.com/gogo/protobuf/jsonpb/jsonpb_test_proto",
                        "revision": "128ef922449da3dbb6c5d942856877a1a7235fef",
--
                        "path": "github.com/gogo/protobuf/proto",
                        "revision": "200875106f3bf0eb01eb297dae30b250a25ffc84",
--
                        "path": "github.com/gogo/protobuf/proto/proto3_proto",
                        "revision": "128ef922449da3dbb6c5d942856877a1a7235fef",
--
                        "path": "github.com/gogo/protobuf/proto/testdata",
                        "revision": "128ef922449da3dbb6c5d942856877a1a7235fef",
--
                        "path": "github.com/gogo/protobuf/protoc-gen-gogo/descriptor",
                        "revision": "200875106f3bf0eb01eb297dae30b250a25ffc84",
--
                        "path": "github.com/gogo/protobuf/sortkeys",
                        "revision": "200875106f3bf0eb01eb297dae30b250a25ffc84",
--
                        "path": "github.com/gogo/protobuf/test",
                        "revision": "200875106f3bf0eb01eb297dae30b250a25ffc84",
--
                        "path": "github.com/gogo/protobuf/test/custom",
                        "revision": "128ef922449da3dbb6c5d942856877a1a7235fef",
--
                        "path": "github.com/gogo/protobuf/test/custom-dash-type",
                        "revision": "128ef922449da3dbb6c5d942856877a1a7235fef",

There are two different revisions mentioned, I smell a rat...

More over, sourcegraph/sourcegraph uses the third variant 

grep gogo -A 1 ../sourcegraph/vendor/vendor.json
                        "path": "github.com/gogo/protobuf",
                        "revision": "4f262e4b0f3a6cea646e15798109335551e21756",
beyang commented 8 years ago

done.