search

sourcegraph / srclib

srclib is a polyglot code analysis library, built for hackability. It consists of language analysis toolchains (currently for Go and Java, with Python, JavaScript, and Ruby in beta) with a common output format, and a CLI tool for running the analysis.
https://srclib.org
Other
942 stars 62 forks source link

gendata: Remove unneeded fmt.Sprintf. #295

Closed dmitshur closed 8 years ago

dmitshur commented 8 years ago

Don't use fmt.Sprintf here since it's not needed.

It's dangerous to provide dynamic input as the first parameter of a printf-like function since it may contain a sequence like %v which would cause a problem.

dmitshur commented 8 years ago

There's a merge conflict now, but resolving it is going to be trivial - this PR is just 2 modified lines.

It just needs to be code reviewed to be able to merge.

keegancsmith commented 8 years ago

LGTM