search

sourcegraph / srclib

srclib is a polyglot code analysis library, built for hackability. It consists of language analysis toolchains (currently for Go and Java, with Python, JavaScript, and Ruby in beta) with a common output format, and a CLI tool for running the analysis.
https://srclib.org
Other
942 stars 62 forks source link

src toolchain add should check current dir before adding #98

Open sqs opened 9 years ago

sqs commented 9 years ago

src toolchain add <TC> should check that the current dir is indeed a toolchain before adding. If it is not a toolchain dir, then a lot of other operations fail with bizarre errors about symlinks.

jelmerdereus commented 9 years ago

@samertm: "ConfigFilename is the file that all toolchains need"

samertm commented 9 years ago

Yup, and the check should be here: https://sourcegraph.com/sourcegraph.com/sourcegraph/srclib@1d19551120a015de42e0cf648bdfa9ddf4061986/.tree/toolchain/add.go#startline=35&endline=35

samer commented 9 years ago

@jelmerdereus wrong Samer :-)

jelmerdereus commented 9 years ago

excuse me @samer😄

jelmerdereus commented 9 years ago

Please have a look @samertm