search

sourcegraph / stylelint-config

Shared stylelint config for all Sourcegraph projects
Apache License 2.0
4 stars 4 forks source link

Add min/max width/height to the unit-allowed-list #210

Closed vovakulikov closed 1 year ago

vovakulikov commented 1 year ago

Just update the unit-allowed list with max-width min-width max-height min-height to avoid unnecessary stylelint disables.

taras-yemets commented 1 year ago

We might not need these changes unless we want to restrict the allowed units for min/max height/width. As they are not specified in declaration-property-unit-allowed-list rule definition we don't need to disable them.

vovakulikov commented 1 year ago

@taras-yemets is right. This PR doesn't block anything but still see the benefit from specifying max/min width/height rules directly since we already have allowed unit list for the width/height CSS declarations. In order to avoid inconsistency, I think we have to specify them too.