search

sourcegraph / syntect_server

HTTP code syntax highlighting server written in Rust.
Other
92 stars 16 forks source link

upstream additions to syntect #3

Open slimsag opened 7 years ago

slimsag commented 7 years ago

The ./syntect folder is a copied / slightly modified version of upstream syntect. I should figure out the correct way to send these changes upstream.

EDIT: there is now much more changes in terms of Packages etc. than just the above that we would want to send upstream^

robinst commented 7 years ago

Hey! Saw that you're planning to contribute syntaxes to syntect.

syntect is currently using the definitions from sublimehq/Packages, and I don't think we'd want to start maintaining a non-trivial fork of those. If you could contribute them there instead, that would be really cool. It would mean not only syntect but also Sublime Text would benefit.

(CC @trishume and @keith-hall, which might be able to help upstream them)

slimsag commented 7 years ago

@robinst Very good point, the syntaxes should be upstreamed to that repo. Thanks for mentioning!

(The themes would still be upstreamed to Syntect, though, since AFAIK there is no standard repo for Sublime themes which Syntect could pull from).

keith-hall commented 7 years ago

I don't think SublimeHQ have any plans ATM to include a TypeScript package with Sublime Text, so that would probably not be accepted (especially if it contains performance reducing features like lookbehinds), but JSX and Swift are desired: https://github.com/sublimehq/Packages/issues/860 and https://github.com/sublimehq/Packages/pull/11

Maybe a better approach (to allow the use of any syntax definitions, regardless of desirability in ST's main repo) would be to have a git repo with submodules that would link to the official packages repo, and other syntax definition repos and use that with syntect?