search

sourcegraph / tree-sitter-jsonnet

tree-sitter grammar for JSONNET
MIT License
16 stars 6 forks source link

Calls with more than 2 arguments are not handled #5

Closed aryx closed 1 year ago

aryx commented 2 years ago

The grammar hardcoded Calls with one or two arguments, but does not allow more. We should use some repeat() in the grammar.

aryx commented 2 years ago

@tjdevries are you accepting pull requests for this repository, or this project is unmaintained and I should create a fork instead?

tjdevries commented 2 years ago

You can create a PR! Sorry, I was on paternity leave during October, so I completely missed this. I'll gladly review!

aryx commented 2 years ago

Fantastic! And congrats for the kid (and good luck ...). I'll try to make a PR in the next few weeks.

aryx commented 2 years ago

As an example of this issue, the tree-sitter-jsonnet parser can't parse std.jsonnet, the official standard library: https://github.com/google/jsonnet/blob/master/stdlib/std.jsonnet