search

sourcegraph / zoekt

Fast trigram based code search
Apache License 2.0
736 stars 83 forks source link

remove SRC_EXPERIMENT_ITERATE_NGRAM_LOOKUP_LIMIT #800

Closed keegancsmith closed 3 months ago

keegancsmith commented 3 months ago

After defaulting to shard merging for all inactive repos, this in fact makes searches slightly slower. So we can remove the experiment.

Test Plan: go test

Data at https://linear.app/sourcegraph/issue/SPLF-174/turn-off-trigram-limit-experiment-and-see-impact-on-dotcom-perf#comment-46e58236

github-actions[bot] commented 3 months ago

Fuzz test failed on commit 7dde8b8bbb2bea99d7fe2f53b668972a04525563. To troubleshoot locally, use the GitHub CLI to download the seed corpus with

gh run download 10199994055 -n testdata
keegancsmith commented 3 months ago

Fuzz test failed on commit 7dde8b8. To troubleshoot locally, use the GitHub CLI to download the seed corpus with

gh run download 10199994055 -n testdata

This seems to be an infra issue in CI, clicking through to the logs there is a connection timeout.