On the results page, if a search result contains a + in the file path, e.g. filename is SwiftFileName+SwiftCategoryName.swift, the URL escapes the + such that it breaks the link.
E.g. if the search result is expected to point to https://github.com/OrganizationName/RepositoryName/path/to/SwiftFileName+SwiftCategoryName.swift, the URL becomes https://github.com/OrganizationName/RepositoryName/path/to/SwiftFileName+SwiftCategoryName.swift, which leads to a broken page.
Why is this a problem?
Poor user experience while navigating results
The + should not be escaped, it's just wrong
Proposed fix
Prevent + from being escaped in result URLs. There might be other symbols getting problematically escaped, but I have not encountered these yet
What is the problem?
On the results page, if a search result contains a
+
in the file path, e.g. filename isSwiftFileName+SwiftCategoryName.swift
, the URL escapes the+
such that it breaks the link.E.g. if the search result is expected to point to
https://github.com/OrganizationName/RepositoryName/path/to/SwiftFileName+SwiftCategoryName.swift
, the URL becomeshttps://github.com/OrganizationName/RepositoryName/path/to/SwiftFileName+SwiftCategoryName.swift
, which leads to a broken page.Why is this a problem?
+
should not be escaped, it's just wrongProposed fix
+
from being escaped in result URLs. There might be other symbols getting problematically escaped, but I have not encountered these yet