search

sourcelevel / faraday-http-cache

A Faraday middleware that respects HTTP cache
Other
343 stars 86 forks source link

Cache fresh responses even if they have 'must-revalidate' #101

Closed jstastny closed 4 years ago

jstastny commented 6 years ago

My take on #100.

This may be naive and/or missing something, but I wanted to open the discussion with this PR.

sourcelevel-bot[bot] commented 6 years ago

Hello, @jstastny! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

jstastny commented 5 years ago

@lucasmazza -- could you, please, take a look at this PR and possibly merge it? Thanks!

lucasmazza commented 5 years ago

@jstastny I'll take a look on this (and do my periodic re-read of the RFC 🏃 ) on the next few days

jstastny commented 5 years ago

@lucasmazza -- any update on this? It would be great to see this merged so we can stop using our fork. Thanks!

jstastny commented 5 years ago

@lucasmazza -- any chance you could take a look at this some time soon?

jstastny commented 4 years ago

@lucasmazza -- sorry to bother, but any chance you would look into this? I would love to stop using our fork of this. Thanks!

lucasmazza commented 4 years ago

@jstastny thanks for the patch and the year long patience 🙏

gradybarrett commented 4 years ago

Any chance of a new version getting released soon that includes this?