search

sourcelevel / faraday-http-cache

A Faraday middleware that respects HTTP cache
Other
343 stars 86 forks source link

Support Faraday 1.0 #118

Closed ybiquitous closed 4 years ago

ybiquitous commented 4 years ago

Hi,

Do you have a plan to support Faraday 1.0, which will be released soon?

The latest version 0.17.3 of Faraday is the last version of the 0.x series.

https://github.com/lostisland/faraday/releases/tag/v0.17.3

ybiquitous commented 4 years ago

FYI. https://github.com/lostisland/faraday/blob/master/UPGRADING.md

johnlcox commented 4 years ago

Is there any ETA on when 1.0 support might be available and released?

ybiquitous commented 4 years ago

The 1.0 due date seems May 3, 2020: https://github.com/lostisland/faraday/milestone/1

marnen commented 4 years ago

1.0 was already released in December. It's a pity that the released version of this gem doesn't support it.

georgeguimaraes commented 4 years ago

Hi, have you tried updating the dependency to Faraday 1.0? I'll take a look into that.

ybiquitous commented 4 years ago

Thank you! It seems that the dependency has been updated via the commit 88772d9349645f873f5db6b787ddf810a860486f!

Looks like this issue can be closed if nobody has an opinion. 😃

marnen commented 4 years ago

@ybiquitous Except that commit hasn’t made it into a release yet, right?

ybiquitous commented 4 years ago

Yes. I hope it will be released soon. 😃

ioquatix commented 4 years ago

Can you please release it?

ioquatix commented 4 years ago

@georgeguimaraes friendly ping :)

georgeguimaraes commented 4 years ago

Released! https://rubygems.org/gems/faraday-http-cache/versions/2.2.0 I haven't tried it with the newer Faraday versions. Please let me know if things break. :)

ybiquitous commented 4 years ago

@georgeguimaraes Thank you!