search

sourcelevel / faraday-http-cache

A Faraday middleware that respects HTTP cache
Other
343 stars 86 forks source link

Spec: Load ActiveSupport Notifications before use #89

Closed olleolleolle closed 8 years ago

olleolleolle commented 8 years ago

This PR adds a require to one of the specs, so that it can pass when run via rake, too.

With this change, this suite passes in Rake, too. Without it, the suite failed becuase that file had 4 test failures on not having loaded the Notifications constant.

With this change, you could change the Travis build to use the default script task instead of the bin/rspec one.

ebert-bot commented 8 years ago

Hello, @olleolleolle! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

lucasmazza commented 8 years ago

Thanks! 😄