sourcemash / Sourcemash

Read Your News Faster.
GNU General Public License v2.0
3 stars 0 forks source link

Add item-card specification. #255

Closed alexgerstein closed 9 years ago

alexgerstein commented 9 years ago

Closes #252.

swglad commented 9 years ago

This looks like it may resolve (or help to resolve) #257, but doesn't do what #252 specifies.

swglad commented 9 years ago

@alexgerstein Did you see the above comment?

alexgerstein commented 9 years ago

Ah. I'm on it.

swglad commented 9 years ago

Also probably goes without saying, but can you run feed-seed and make sure the feed cards look nice given the set of feeds we have loaded? If we fix our design to accommodate this set of feeds, that's not a bad thing

alexgerstein commented 9 years ago

How else was I going to make sure the two-col solution was working!?!

swglad commented 9 years ago

Talking about two separate but related issues: two vs. three columns is one, but style of feed cards vs. item cards is another. Just making sure we maximize both!

alexgerstein commented 9 years ago

@swglad It's ready.

swglad commented 9 years ago

Why did my merging the MixPanel branch just merge this one?