search

sourcenetwork / defradb

DefraDB is a Peer-to-Peer Edge Database. It's the core data storage system for the Source Network Ecosystem, built with IPLD, LibP2P, CRDTs, and Semantic open web properties.
444 stars 43 forks source link

linters deadcode and varcheck deprecated in golangci-lint v1.49 #817

Closed orpheuslummis closed 1 year ago

shahzadlone commented 2 years ago

You beat me to it.

One thing to keep in mind is this is only an issue locally for now as our CI is locked to a version before this.

orpheuslummis commented 2 years ago

unsure, but I suggest we find replacements for the functionalities of these 'lost' linters, if possible

shahzadlone commented 2 years ago

No, they were deprecated because they were doing repetitive tasks (similar to unused and some others). When we bump our CI to 1.49 we can handle this, it's a trivial fix.

orpheuslummis commented 2 years ago

ok, nice

shahzadlone commented 2 years ago

Blocked until this is fixed: https://github.com/golangci/golangci-lint-action/issues/540 Because of this issue: https://github.com/golangci/golangci-lint-action/issues/535

The issue that made us hard code to version v1.47 still persists (#727) lint action uses the default built binary that enforces go v1.19 formatting.

suggest waiting for this until that is fixed (or else we would manually have to build golang-ci every time in the CI).

Or until we bump to GoLang v1.19