search

sourcepole / qgis-instantprint-plugin

QGIS Instant Print Plugin
GNU General Public License v2.0
10 stars 10 forks source link

Modifications for multilingualization #34

Closed yamamoto-ryuzo closed 2 years ago

yamamoto-ryuzo commented 2 years ago

I think it will be OK this time.

pka commented 2 years ago

@yamamoto-ryuzo thanks a lot for your PR! I had a look at the changes and some translations changing from "obsolete" to "unfinished" look a bit suspicious to me. I'll ask @manisandro to have another look at the PR.

yamamoto-ryuzo commented 2 years ago

This is my first time collaborating on GitHUB. I understand what you guys are fixing, but should I do something? I don't understand. Sorry.

manisandro commented 2 years ago

Yes, just push follow-up commits to your fork with the requested changes, and then the PR will update itself automatically.

yamamoto-ryuzo commented 2 years ago

Is this correct?

yamamoto-ryuzo commented 2 years ago

changing from "obsolete" to "unfinished" ↑　By the way, how can I do the above?

↓　It is auto-generated. image

manisandro commented 2 years ago

If you open the ts file in qt linguist, you can mark the translaton as finished: image

yamamoto-ryuzo commented 2 years ago

I marked the Japanese. Should I mark other translations as well? I have not been able to confirm the translation. image

yamamoto-ryuzo commented 2 years ago

What else should I do?

manisandro commented 2 years ago

Thanks!

yamamoto-ryuzo commented 2 years ago

I should have simply marked it as complete. Thank you very much.