sourcepole / qgis-instantprint-plugin

QGIS Instant Print Plugin
GNU General Public License v2.0
10 stars 10 forks source link

digitize feature added #8

Closed enricofer closed 1 year ago

enricofer commented 6 years ago

A cartographer ask me to add a button to instantprint dialor for digitizing the current rubberband map frame to the current active layer for easing the creation of touristic maps coverage. Feel free to merge PR if you find the feature could have wide interest.

manisandro commented 6 years ago

So the goal is to have a persistent store of areas already printed?

enricofer commented 6 years ago

This could be, but the real aim of the user who asked me to modify the plugin was to digitize many printing areas on a coverage layer to be used as atlas context for printing. They draw touristic maps on ArcMap that can draw on data frame the graphical objects on layout accordingly with target scale. Now they want to migrate to QGIS and they don't find any similar needed feature.

2017-07-17 11:46 GMT+02:00 Sandro Mani notifications@github.com:

So the goal is to have a persistent store of areas already printed?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sourcepole/qgis-instantprint-plugin/pull/8#issuecomment-315710819, or mute the thread https://github.com/notifications/unsubscribe-auth/AHMgg1-cjRC0sDw4M9ifudmEdJS5AKvFks5sOy1-gaJpZM4OYJpD .

manisandro commented 6 years ago

Ah so it's basically just "abusing" the print dialog to compute the rectangle which corresponds to a given scale?

enricofer commented 6 years ago

Yes it is. Tell me if you see a way to better generalize the feature.

2017-07-17 12:10 GMT+02:00 Sandro Mani notifications@github.com:

Ah so it's basically just "abusing" the print dialog to compute the rectangle which corresponds to a given scale?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sourcepole/qgis-instantprint-plugin/pull/8#issuecomment-315715724, or mute the thread https://github.com/notifications/unsubscribe-auth/AHMggxcbB5x4u6fjdyDpuzkj_Lfcp-RMks5sOzMdgaJpZM4OYJpD .

manisandro commented 6 years ago

So is there any relation at all with a print composer, or did you consider just extracting the necessary code to compute the extent based on paper size and scale and create a dedicated plugin for it?

enricofer commented 6 years ago

The typical workflow is composing a layout with a map at a fixed scale, then on map canvas digitize the composer map extension in map units on a coverage layer, and finally come back to composer to generate ad atlas with the coverage layer as context. Now the cartographer user is happy with custom istantPrint plugin. Writing a new plugin seem to me like reinventing the wheel, and I can't imagine another use of the hack, so feel free to keep the PR I provide you only if you find it has a wider field of interest.

2017-07-17 13:21 GMT+02:00 Sandro Mani notifications@github.com:

So is there any relation at all with a print composer, or did you consider just extracting the necessary code to compute the extent based on paper size and scale and create a dedicated plugin for it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sourcepole/qgis-instantprint-plugin/pull/8#issuecomment-315728824, or mute the thread https://github.com/notifications/unsubscribe-auth/AHMgg2bWxl--KkJkt5qBFRJYM3tN4wB3ks5sO0PEgaJpZM4OYJpD .

HusseinKabbout commented 1 year ago

Closing this PR as it is obsolete.