search

sourcerer-io / hall-of-fame

:trophy: Show some love to your contributors! A widget for your repo README. Visual and clean. Refreshes every hour.
MIT License
947 stars 88 forks source link

Load blank images when <7 contributors #12

Closed bobheadxi closed 6 years ago

bobheadxi commented 6 years ago

Just an idea, but looks like when you have <7 contributors, on some systems a not-very-nice placeholder is shown:

blank

Example is from this repo. https://github.com/sourcerer-io/hall-of-fame#contributing

Potential solution could be to serve up a blank image

sergey48k commented 6 years ago

Hi Robert,

There is an invisible SVG there. What you see happens when occasionally GitHub does not serve an image properly. Just refresh. Same thing happens to badges for instance. It's annoying but beyond our control.

Best, Sergey

On Fri, Aug 10, 2018 at 4:17 PM, Robert Lin notifications@github.com wrote:

Just an idea, but looks like when you have <7 contributors, on some systems a not-very-nice placeholder is shown:

[image: blank] https://user-images.githubusercontent.com/23356519/43984962-bcea1888-9cb8-11e8-87cf-ebb9ffd17d2d.PNG

Example is from this repo. https://github.com/sourcerer- io/hall-of-fame#contributing

Potential solution could be to serve up a blank image

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sourcerer-io/hall-of-fame/issues/12, or mute the thread https://github.com/notifications/unsubscribe-auth/ATWQf4lJpQwNw_f1P4pvPKK5dd38buDSks5uPhR7gaJpZM4V47QI .

sergey48k commented 6 years ago

Just to clarify: GitHub seems to be using some sort of a cache for images linked from READMEs. Occasionally, it does not load those images properly. So they show as they didn't load by the browser. This behavior happens for shields/badges, pictures in repo, etc. We are no different.