hall of fame should filter bot/app accounts

sourcerer-io / hall-of-fame

:trophy: Show some love to your contributors! A widget for your repo README. Visual and clean. Refreshes every hour.

MIT License

947 stars 88 forks source link

hall of fame should filter bot/app accounts #22

Closed chris48s closed 6 years ago

chris48s commented 6 years ago

If I generate a hall of fame for this repo https://github.com/badges/shields

dependabot is included as a contributor:

hof2

(additionally, the link it generates for the bot's "profile" is https://github.com/dependabot[bot] which is a 404. If anything it should be https://github.com/apps/dependabot )

However, I think if it is possible to identify activity from github app/bot accounts these should ideally be excluded in favour of human contributors.

sergey48k commented 6 years ago

Added a fix and released to production: https://github.com/sourcerer-io/hall-of-fame/commit/4ef1aa9fd271b9cde787fc1ab4b5d8b915fc9ba3