search

sourcerer-io / sourcerer-app

🦄 Sourcerer app makes a visual profile from your GitHub and git repositories.
https://sourcerer.io/start
MIT License
6.73k stars 281 forks source link

feat: Adds Byond detection support #562

Closed CorruptComputer closed 4 years ago

CorruptComputer commented 4 years ago

I finally got around to this, but this is to support this PR: https://github.com/sourcerer-io/awesome-libraries/pull/104

Please let me know if any changes are needed!

yaronskaya commented 4 years ago

Hi @CorruptComputer. Thank you for adding that. Is Byond a part of DM language? Github classify it as DM language now. What is a way to import libraries in code in that language?

CorruptComputer commented 4 years ago

Hi @yaronskaya DM is the custom language Byond created for their game engine. I don't believe that libraries are able to be imported, as all of the code written must be attached to an object in the game world.

yaronskaya commented 4 years ago

@CorruptComputer Would it be more correct to assign DM as language of a code? Regarding the libraries, what are these items that you provided in awesome-libraries PR? Are these libraries or not?

I'm asking because we need to clarify the language specifics before reviewing PRs.

CorruptComputer commented 4 years ago

Possibly? Those are the different kinds of files you can have in the project, for example .dm is for the code. .dmm is for the mapping, and .dmi is for the sprites you create within the editor.

The only reason I lumped them all into Byond is that none of the code can be used outside of this engine.

yaronskaya commented 4 years ago

@CorruptComputer got it.

  1. Let's assign .dm, .dmi, .dmm to DM language in Heuristics.kt
  2. Let's assign .dmi, .dmm to Byond technology. See example where we assigned all .vue files to Vue technology in javascript. Basically, you will need to create DMExtractor and override extractLibStats function.
  3. I'll add the combining of DM files and Byond technology to Byond on our backend so that when a repo has Byond technology and .dm files then .dm will be threated as Byond.

Does that work for you?

CorruptComputer commented 4 years ago

That works for me :+1:

I'll start working on that now.

CorruptComputer commented 4 years ago

I believe I have made the requested changes, I'm not very familiar with Kotlin and this is actually my first time working with it. Please tell me if anything else needs changes!

CorruptComputer commented 4 years ago

@yaronskaya I've made the requested changes, are there any changes needing to be made to sourcerer-io/awesome-libraries#104?