key/value pair not being wrapped in parentheses with itertools.product refactorig

sourcery-ai / sourcery

Instant AI code reviews

https://sourcery.ai

MIT License

1.53k stars 66 forks source link

key/value pair not being wrapped in parentheses with itertools.product refactorig #248

Closed angrycaptain19 closed 2 years ago

angrycaptain19 commented 2 years ago

Sourcery suggested a nifty Python refactoring to move from nested for loops to using itertools.product

The bug is that the 2nd set of key/values should also be wrapped in parentheses like domain_key and domain_v are. When doing the refactoring those were left out and caused an error.

unnamed (9)

bm424 commented 2 years ago

@Hellebore can you confirm this will be resolved in the next release?

Hellebore commented 2 years ago

Resolved with release of 0.12.1