Closed bwagner closed 2 years ago
Thanks for reporting this @bwagner. I have reproduced and have a fix for the next release
Still present in Sourcery 4.57
Hi, @bwagner!
A fix for this issue was released in Sourcery v0.12.7. The expected behavior now is for Sourcery to refactor
a = {'a': 'b'}
a.update({k: a[v] for k, v in {'c': 'a'}.items()})
as
a = {'a': 'b'}
a |= {k: a[v] for k, v in {'c': 'a'}.items()}
which preserves semantics.
Can you make sure you are running v0.12.7 and check again?
Closing this issue as completed since a fix was released in Sourcery v0.12.7, but feel free to re-open it if you still find this bug even after updating Sourcery :grin:
Thanks again for opening this bug report!
Semantics-breaking refactoring suggested by Sourcery "Merge dictionary updates via the union operator"
Code before:
When refactoring is applied, we get invalid code (
a
is referred to before it exists):a = {'a': 'b'} | {k: a[v] for k, v in {'c': 'a'}.items()}
Sourcery Version
Often available in Sourcery settings: Not in my version, but it's current.
Code editor or IDE name and version
PyCharm 2022.2 (Professional Edition) Build #PY-222.3345.131, built on July 27, 2022
OS name and version
OSX / macOS: 10.14.6 (Mojave)