Closed TheMythologist closed 1 year ago
Hi,
Thanks for reporting this. You're right this refactoring works only with 2 isinstance
calls, but it could work for 3 or more isinstance
calls as well.
We'll probably look into this some time in the autumn.
Some background info We have a similar "2 vs more" topic for some other refactorings as well. :slightly_smiling_face: We've introduced some new syntax to our refactoring DSL, which will enable us to make these refactorings more flexible. The new syntax still needs some cleanup, but afterwards we'll tackle these cases.
Cheers, Reka
This should go live with the next release.
Noe live with 0.12.8
👍 works, thanks!
Checklist
Description
The "merge-isinstance" refactor is incomplete - it only offers the refactoring when two
isinstance
calls are separated by anor
. The refactoring doesn't show up if there are more than twoisinstance
calls.Debug Information
IDE Version: Visual Studio Code 1.71.0
Sourcery Version: Sourcery 0.12.7
Operating system and Version: Windows 10 - 10.0.19044 Build 19044