search

sourcery-ai / sourcery

Instant AI code reviews
https://sourcery.ai
MIT License
1.5k stars 65 forks source link

Error while updating 'Sourcery' extension. #330

Closed pzelnip closed 1 year ago

pzelnip commented 1 year ago

Checklist

Description

Using VS Code, I'm told that there's an update available for Sourcery: https://cdn.zappy.app/e5cc449213581a7ab65ac8360b78e707.png

Clicking Update causes an error to happen: https://cdn.zappy.app/16d8a83d0ed801df0bc79c425f2a6e3d.png

I've tried restarting VS Code multiple times and also tried in different VS Code windows, problem is persisting. Contents of the linked log:

2023-03-30 12:48:42.137 [error] CorruptZip: end of central directory record signature not found
    at yt.download (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:93:141)
    at async j.y (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:93:20893)
    at async j.h (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:93:18962)
2023-03-30 12:48:42.157 [error] end of central directory record signature not found: CorruptZip: end of central directory record signature not found
    at yt.download (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:93:141)
    at async j.y (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:93:20893)
    at async j.h (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/code/node/sharedProcess/sharedProcessMain.js:93:18962)

Code snippet that reproduces issue

N/A

Debug Information

IDE Version:

Version: 1.77.0 Commit: 7f329fe6c66b0f86ae1574c2911b681ad5a45d63 Date: 2023-03-29T09:55:48.214Z Electron: 19.1.11 Chromium: 102.0.5005.196 Node.js: 16.14.2 V8: 10.2.154.26-electron.0 OS: Darwin arm64 21.6.0 Sandboxed: No

Sourcery Version:

v1.0.9

Operating system and Version:

OSX Monterey 12.6.3 (macbook pro, M1-Pro chip)

reka commented 1 year ago

Thanks a lot for reporting this issue. We're looking into it.

pzelnip commented 1 year ago

FWIW, I don't think this is an M1-specific issue, on my other Macbook (an M1-air) it's updated fine (am running 1.1.0).

On this machine I've uninstalled Sourcery, and now upon trying to install it fresh I get the same error though. :(

bm424 commented 1 year ago

Hi @pzelnip - I've just taken a quick look at this and I'm pretty certain this isn't an issue with the Sourcery release. If you search something along the lines of "end of central directory record signature not found CorruptZip" you can find a series of similar problems other users have had with VSCode extensions of all types. I suggest deleting any sourcery folders in your ~/.vscode/extensions directory and trying to re-install. Hope that helps.

pzelnip commented 1 year ago

FWIW, after I uninstalled sourcery the sourcery folder in ~/.vscode/extensions was gone, but I still got the same error when trying to reinstall. I then installed manually from the vsix file, and it installed successfully, hopefully I won't have to do this manually whenever there's a new version of the sourcery extension, but we shall see. 😄

Thanks for looking into this.