sourcery-ai / sourcery

Instant AI code reviews
https://sourcery.ai
MIT License
1.5k stars 65 forks source link

Sourcery PyCharm plugin does not respect/obey the inspection settings set by PyCharm #343

Open ColemanDunn opened 1 year ago

ColemanDunn commented 1 year ago

Checklist

Description

Sourcery PyCharm plugin does not respect/obey the inspection settings set by PyCharm. For example, the default inspection for sourcery is warning severity and a warning highlighting in editor.

here I have set it to weak warning severity and highlighting:

image

it is still a warning (after invalidating all caches and restarting)

image

If I turn it off completely in inspections it does indeed turn off but does not respect the changed inspections.

Code snippet that reproduces issue

listing_kwargs = {}
for key, value in some_other_dict1.items():
    if key in some_other_dict2:
        listing_kwargs[key] = value

Debug Information

IDE Version:

Pycharm 2023.1 (but it has done this in previous versions as well)

Sourcery Version:

1.2.0

Screenshot 2023-04-28 at 11 08 25 AM

Operating system and Version:

Apple M1 Max Ventura 13.3.1 (22E261)

Hellebore commented 1 year ago

Thanks for raising this, and apologies for the delay in replying. I agree it would be nicer if we respected these settings.