Enabling Sourcery causing some PEP8 checks to stop appearing in PyCharm

sourcery-ai / sourcery

Instant AI code reviews

https://sourcery.ai

MIT License

1.5k stars 65 forks source link

Enabling Sourcery causing some PEP8 checks to stop appearing in PyCharm #363

Open Hellebore opened 1 year ago

Hellebore commented 1 year ago

Checklist

[x] I have searched the Sourcery documentation for the issue, and found nothing
[x] I have checked there are no open bugs referencing the same bug or problem

Description

When I install the sourcery addin, the PyCharm built-in PEP8 checks stop working.

I have tried a completely clean install and when I first install PyCharm the PEP8 checks are working but as soon as I then install sourcery, they stop reporting.

Code snippet that reproduces issue

Debug Information

IDE Version: latest versions of PyCharm (2023.1.3)

Sourcery Version: sourcery (1.4.0).

Operating system and Version:

Hellebore commented 1 year ago

Haven't been able to reproduce this issue.

Hellebore commented 12 months ago

Possible solution found - testing it - According to JetBrains support the ExternalAnnotatorsFilter that we are using applies to all external annotators not just our own.

charleslstone commented 12 months ago

Thanks for working on this. I noticed the same issue today with Pycharm no longer highlighting too few or too many blank lines before functions, class methods and at end of module. Took a while to track it down to Sourcery, but found if I disable Sourcery, these PEP8 warning appear....if I enable Sourcery, these warnings do not appear. Otherwise, really great product and I have enjoyed using it.

Hellebore commented 12 months ago

Thanks @charleslstone! The possible fix will be in the next release (I can't actually reproduce this locally to verify)