sourcery-ai / sourcery

Instant AI code reviews
https://sourcery.ai
MIT License
1.5k stars 65 forks source link

Sourcery should ignore `# noqa` lines #379

Open Bilbottom opened 10 months ago

Bilbottom commented 10 months ago

Checklist

Description

This might be a design choice (in which case, close this immediately 😋), but currently Sourcery doesn't ignore lines with the # noqa trailing comment. Although # noqa isn't a recommended way of suppressing QA warnings, there are occasional places where it's helpful.

It would be awesome if both the CLI and the IDE interfaces would ignore lines with the # noqa trailing comment. A minimal example in PyCharm to show that this currently isn't the case is in the screenshot below:

image

bm424 commented 10 months ago

Hi @Bilbottom! Thank you for this great suggestion, it's definitely something we'll consider.