feat: review should be updated or create a new one.

sourcery-ai / sourcery

Instant AI code reviews

https://sourcery.ai

MIT License

1.56k stars 71 forks source link

feat: review should be updated or create a new one. #427

Closed cnlangzi closed 5 months ago

cnlangzi commented 7 months ago

Checklist

[x] This is a new feature, not a refactoring suggestion
[x] I have checked for this feature in the Sourcery documentation
[x] I have checked there are no open requests referencing the same feature

Description

for now, sourcery ai create review as comment. It is impossible to click request re-review. and the review will be out of date if any new commit is pushed. could we update it or create a new one with latest code again?

Hellebore commented 7 months ago

@cnlangzi thanks for raising - this is on our roadmap and coming up shortly.

How would you prefer to request a re-review? Options we're considering (also open to others):

comment something like @sourcery-ai review
adding a label
a checkbox in our summary comment

cnlangzi commented 7 months ago

@cnlangzi thanks for raising - this is on our roadmap and coming up shortly.

How would you prefer to request a re-review? Options we're considering (also open to others):

comment something like @sourcery-ai review

adding a label

a checkbox in our summary comment

as human review, we will ask him to re-review when code is updated based on his comments.

@sourcery-ai review make senses. if so, maybe it is easier to do it automatically if code is updated. eg dependabot, deepsource-io or codecov.

on dependabot, comment commands are optional. I just write it when I want to trigger it starts task immediately.

re review, to use built-in feature should be more friendly than new comment commands/label...etc.

ruancomelli commented 5 months ago

Hello, @cnlangzi!

We recently released an update that allows you to request new reviews from Sourcery. Just comment

@sourcery-ai review

on a PR, and the Sourcery bot will start a new review.

Unfortunately, the built-in re-request feature can only be used to re-request reviews from human reviewers, not bots (like Sourcery).

Thanks for reaching out!

cnlangzi commented 5 months ago

@ruancomelli it seems don't work properly. please check https://github.com/yaitoo/sqle/pull/47#pullrequestreview-2111727897

A new null.go file was added. but the robot says it is reviewed.

ruancomelli commented 5 months ago

Hey @cnlangzi! This looks like a bug in the re-review mechanics. I opened a new GitHub issue to track this down: https://github.com/sourcery-ai/sourcery/issues/428.