search

sourceryinstitute / ISO_Fortran_binding

C/Fortran interoperability library
BSD 3-Clause "New" or "Revised" License
17 stars 0 forks source link

Refactor tests to remove reliance on VLAs #10

Closed zbeekman closed 5 years ago

zbeekman commented 6 years ago

The core library builds with clang on macOS. However, one or more tests use VLAs. We should, at some point, refactor these to remove this.

rouson commented 5 years ago

Because the only immediate prospects for use of this repository lie with GCC and because gcc supports non-standard VLAs as an extension, I'll mark this as "won't fix" and close it. There's also at least one other Fortran compiler that uses gcc as its companion C compiler: the NAG Fortran compiler. So there's also the possibility that this repository can be used with that compiler without removing VLAs.

The other open-source compiler that might have been a target for this repository's code is the flang compiler, but flang will at some point be replaced by f18, which already has its own implementation of ISO_Fortran_binding.h.

zbeekman commented 5 years ago

OK. It should be noted that most people consider this more than a cosmetic problem, and consider VLAs to bee poor practice/dangerous, AFAICT, however I doubt anyone will work on this anytime soon, so we may as well close it.

On Thu, Oct 11, 2018 at 3:36 PM Damian Rouson notifications@github.com wrote:

Because the only immediate prospects for use of this repository lie with GCC and because gcc supports non-standard VLAs as an extension, I'll mark this as "won't fix" and close it. There's also at least one other Fortran compiler that uses gcc as its companion C compiler: the NAG Fortran compiler. So there's also the possibility that this repository can be used with that compiler without removing VLAs.

The other open-source compiler that might have been a target for this repository's code is the flang https://github.com/flang-compiler/flang compiler, but flang will at some point be replaced by f18 https://github.com/flang-compiler/f18, which already has its own implementation of ISO_Fortran_binding.h https://github.com/flang-compiler/f18/blob/master/include/flang/ISO_Fortran_binding.h .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/sourceryinstitute/ISO_Fortran_binding/issues/10#issuecomment-429090448, or mute the thread https://github.com/notifications/unsubscribe-auth/AAREPCTHBxK-7ghpk-Esx7IZIVNidlWvks5uj53EgaJpZM4WAOLC .