jbmaggard
commented
7 years ago @zbeekman
Here is an update. I had some time available over the weekend, so I went forward with the implementation with Intel-MPI working the same way as MPICH on Linux (using mpirun, mpicc, and mpifort bash scripts).
Here is my current configuration for native Win64/MSYS/GCC/Intel-MPI/OpenCoarrays-1.9.2:
$ uname -a
MINGW64_NT-6.1 PE-MGR-LAPTOP 2.9.0(0.318/5/3) 2017-09-13 23:16 x86_64 Msys
$ mpirun --version
Intel(R) MPI Library for Windows* OS, Version 2018 Build 20170713
$ mpicc --version
gcc.exe (Rev1, Built by MSYS2 project) 7.2.0
$ mpifort --version
GNU Fortran (Rev1, Built by MSYS2 project) 7.2.0
$ mpicc -show
gcc -I/c/Intel-MPI/include -L/c/Intel-MPI/lib -Wl,-rpath -Wl,/c/Intel-MPI/lib -lmpi
$ mpifort -show
gfortran -I/c/Intel-MPI/include -I/c/Intel-MPI/include -L/c/Intel-MPI/lib -Wl,-rpath -Wl,/c/Intel-MPI/lib -lmpi
$ echo $PATH
/c/Intel-MPI/bin:/mingw64/bin:/usr/local/bin:/usr/bin:/bin:/c/Windows/System32:/c/Windows
$ echo $MPI_HOME
/c/Intel-MPIHere are my changes to 1.9.2:
- Fixed the OpenCoarrays-1.9.2/CMakeLists.txt per #456
$ diff CMakeLists.txt ../CMakeLists.txt.orig 219c219 < OUTPUT_STRIP_TRAILING_WHITESPACE --- > OUTPUT_STRIP_TRAILING_WHITES_SPACE - MSYS has GCC 7.2.0, so adjusted acceptable_compiler.f90.
$ diff prerequisites/acceptable_compiler.f90 ../acceptable_compiler.f90.orig 38c38 < print *,(compiler_version() >= "GCC version 6.1.0 ") .and. (compiler_version() < "GCC version 7.9.0 ") --- > print *,(compiler_version() >= "GCC version 6.1.0 ") .and. (compiler_version() < "GCC version 7.0.0 ") - Fixed src/mpi/CMakeLists.txt per this defect report (see HAVE_SIGKILL2 variable), and also typo fixed, per #452 . Set CMAKE_REQUIRED_INCLUDES before checking mpi.h for I_MPI_VERSION (introspection for Intel-MPI, to set -DUSE_GCC for long long typedef of MPI_Aint, and long long typedef of MPI_Offset).
$ diff src/mpi/CMakeLists.txt ../CMakeLists.txt.mpi.orig 52,54c52,53 < CHECK_SYMBOL_EXISTS(SIGKILL "signal.h" HAVE_SIGKILL2) < if(HAVE_SIGKILL2) < set(HAVE_SIGKILL ${HAVE_SIGKILL2}) --- > CHECK_SYMBOL_EXISTS(SIGKILL "signal.h" HAVE_SIGKILL) > if(HAVE_SIGKILL) 119,128c118 < #JBM Set CMAKE_REQUIRED_INCLUDES before checking for I_MPI_VERSION < set(old_cmake_required_includes "${CMAKE_REQUIRED_INCLUDES}") < if(CMAKE_REQUIRED_INCLUDES) < set(CMAKE_REQUIRED_INCLUDES ${CMAKE_REQUIRED_INCLUDES};${MPI_C_INCLUDE_PATH}) < else() < set(CMAKE_REQUIRED_INCLUDES ${MPI_C_INCLUDE_PATH}) < endif() < CHECK_INCLUDE_FILES("mpi.h" HAVE_MPI_H) < CHECK_SYMBOL_EXISTS(I_MPI_VERSION "mpi.h" HAVE_Intel_MPI) < message("-- WIN32=" ${WIN32}) --- > CHECK_SYMBOL_EXISTS(I_MPI_VERSION mpi.h HAVE_Intel_MPI) 163,164c153,154 < COMMAND ${CMAKE_COMMAND} -E create_symlink "./${mod_dir_tail}/opencoarrays.mod" "${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_INCLUDEDIR}/opencoarrays.mod" < COMMENT "Creating symlink ${CMAKE_INSTALL_INCLUDEDIR}/opencoarrays.mod --> ${CMAKE_INSTALL_INCLUDEDIR}/${mod_dir_tail}/opencoarrays.mod") --- > COMMAND ${CMAKE_COMMAND} -E create_symlink "./${mod_dir_tail}/opencoarrays.mod" "${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_INCLUDEDIR}/opencaorrays.mod" > COMMENT "Creating symlink ${CMAKE_INSTALL_INCLUDEDIR}/opencaorrays.mod --> ${CMAKE_INSTALL_INCLUDEDIR}/${mod_dir_tail}/opencoarrays.mod") - It is necessary to use -G "MSYS Makefiles" for cmake to find gcc and gfortran, and while I reviewed #305 , #338 , and #359 , and tried both -M option of install.sh and setting $MPI_HOME, cmake was stopping with error about not finding MPI. So, I added -DMPI_C_LIBRARIES, -DMPI_C_INCLUDE_PATH, -DMPI_Fortran_LIBRARIES, and -DMPI_Fortran_INCLUDE_PATH.
With a little work, these changes to build_opencoarrays.sh may be suitable for implementation in master. For example, using uname or cmake to set a variable for the -G option for all systems, and also the items with $MPI_HOME as shown.
$ diff prerequisites/install-functions/build_opencoarrays.sh ../build_opencoarrays.sh.orig
34,35c34,35
< info "CC=\"${CC}\" FC=\"${FC}\" $CMAKE \"${opencoarrays_src_dir}\" -G \"MSYS Makefiles\" -DCMAKE_INSTALL_PREFIX=\"${install_path}\" -DMPIEXEC=\"${MPIEXEC}\" -DMPI_C_COMPILER=\"${MPICC}\" -DMPI_C_LIBRARIES=\"${MPI_HOME}/lib/libmpi.a\" -DMPI_C_INCLUDE_PATH=\"${MPI_HOME}/include\" -DMPI_Fortran_COMPILER=\"${MPIFC}\" -DMPI_Fortran_LIBRARIES=\"${MPI_HOME}/lib/libmpi.a\" -DMPI_Fortran_INCLUDE_PATH=\"${MPI_HOME}/include\""
< CC="${CC}" FC="${FC}" $CMAKE "${opencoarrays_src_dir}" -G "MSYS Makefiles" -DCMAKE_INSTALL_PREFIX="${install_path}" -DMPIEXEC="${MPIEXEC}" -DMPI_C_COMPILER="${MPICC}" -DMPI_C_LIBRARIES="${MPI_HOME}/lib/libmpi.a" -DMPI_C_INCLUDE_PATH="${MPI_HOME}/include" -DMPI_Fortran_COMPILER="${MPIFC}" -DMPI_Fortran_LIBRARIES="${MPI_HOME}/lib/libmpi.a" -DMPI_Fortran_INCLUDE_PATH="${MPI_HOME}/include"
---
> info "CC=\"${CC}\" FC=\"${FC}\" $CMAKE \"${opencoarrays_src_dir}\" -DCMAKE_INSTALL_PREFIX=\"${install_path}\" -DMPIEXEC=\"${MPIEXEC}\" -DMPI_C_COMPILER=\"${MPICC}\" -DMPI_Fortran_COMPILER=\"${MPIFC}\""
> CC="${CC}" FC="${FC}" $CMAKE "${opencoarrays_src_dir}" -DCMAKE_INSTALL_PREFIX="${install_path}" -DMPIEXEC="${MPIEXEC}" -DMPI_C_COMPILER="${MPICC}" -DMPI_Fortran_COMPILER="${MPIFC}"Here is output from install.sh run from the OpenCoarrays-1.9.2 directory. Note the mpi.mod in the $MPI_HOME/include directory was built with ifort and not gfortran (and Intel does not seem to provide the .f90 source to build mpi.mod), so the test for MPI_Fortran_MODULE_COMPILES fails. Also note that the second attempt at finding SIGKILL works, as discussed above in item 3 src/mpi/CMakeLists.txt changes.
$ rm -rf build/ prerequisites/builds/opencoarrays/
$ ./install.sh -i /home/bmaggard/oca/OpenCoarrays-1.9.2/build
2017-10-16 06:17:34 UTC [ info] __file: /home/bmaggard/oca/OpenCoarrays-1.9.2/install.sh
2017-10-16 06:17:34 UTC [ info] __dir: /home/bmaggard/oca/OpenCoarrays-1.9.2
2017-10-16 06:17:34 UTC [ info] __base: install
2017-10-16 06:17:34 UTC [ info] __os: Linux
2017-10-16 06:17:34 UTC [ info] __usage: /home/bmaggard/oca/OpenCoarrays-1.9.2/install.sh-usage
2017-10-16 06:17:34 UTC [ info] LOG_LEVEL: 6
2017-10-16 06:17:34 UTC [ info] -b (--install-branch):
2017-10-16 06:17:34 UTC [ info] -B (--list-branches):
2017-10-16 06:17:34 UTC [ info] -c (--with-c):
2017-10-16 06:17:34 UTC [ info] -C (--with-cxx):
2017-10-16 06:17:34 UTC [ info] -d (--debug): 0
2017-10-16 06:17:34 UTC [ info] -D (--print-downloader):
2017-10-16 06:17:34 UTC [ info] -e (--verbose): 0
2017-10-16 06:17:34 UTC [ info] -f (--with-fortran):
2017-10-16 06:17:34 UTC [ info] -h (--help): 0
2017-10-16 06:17:34 UTC [ info] -i (--install-prefix): /home/bmaggard/oca/OpenCoarrays-1.9.2/build
2017-10-16 06:17:34 UTC [ info] -I (--install-version):
2017-10-16 06:17:34 UTC [ info] -j (--num-threads): 1
2017-10-16 06:17:34 UTC [ info] -l (--list-packages): 0
2017-10-16 06:17:35 UTC [ info] -m (--with-cmake):
2017-10-16 06:17:35 UTC [ info] -M (--with-mpi):
2017-10-16 06:17:35 UTC [ info] -n (--no-color): 0
2017-10-16 06:17:35 UTC [ info] -o (--only-download): 0
2017-10-16 06:17:35 UTC [ info] -p (--package): opencoarrays
2017-10-16 06:17:35 UTC [ info] -P (--print-path):
2017-10-16 06:17:35 UTC [ info] -u (--from-url):
2017-10-16 06:17:35 UTC [ info] -U (--print-url):
2017-10-16 06:17:35 UTC [ info] -v (--version): 0
2017-10-16 06:17:35 UTC [ info] -V (--print-version):
2017-10-16 06:17:35 UTC [ info] -y (--yes-to-all): 0
2017-10-16 06:17:35 UTC [ info] -z (--disable-bootstrap):0
2017-10-16 06:17:35 UTC [ info] install_path="/home/bmaggard/oca/OpenCoarrays-1.9.2/build"
2017-10-16 06:17:35 UTC [ info] num_threads="1"
2017-10-16 06:17:35 UTC [ info] opencoarrays_src_dir=/home/bmaggard/oca/OpenCoarrays-1.9.2
2017-10-16 06:17:35 UTC [ info] build_path="/home/bmaggard/oca/OpenCoarrays-1.9.2"/prerequisites/builds
2017-10-16 06:17:35 UTC [ info] build_script="/home/bmaggard/oca/OpenCoarrays-1.9.2"/prerequisites/build.sh
2017-10-16 06:17:38 UTC [ info] ${LD_LIBRARY_PATH} is empty. Try setting it if the compiler encounters linking problems.
2017-10-16 06:17:38 UTC [ info] Checking whether the directory /home/bmaggard/oca/OpenCoarrays-1.9.2/build exists...
2017-10-16 06:17:38 UTC [ info] no
2017-10-16 06:17:38 UTC [ info] Checking whether I can create /home/bmaggard/oca/OpenCoarrays-1.9.2/build ...
2017-10-16 06:17:38 UTC [ info] yes.
*** By default, building OpenCoarrays requires CMake 3.4.0 or later, ***
*** MPICH 3.2, and GCC Fortran (gfortran) 6.1.0 or later. To see ***
*** options for forcing the use of older or alternative packages, execute ***
*** this script with the -h flag. This script will recursively traverse ***
*** the following dependency tree, asking permission to download, build, ***
*** and install any packages that are required for building another ***
*** package and are neither in your PATH nor in ***
*** opencoarrays/prerequisites/installations: ***
opencoarrays
├── cmake-3.4.0
└── mpich-3.2
└── gcc-6.1.0
├── flex-2.6.0
│ └── bison-3.0.4
│ └── m4-1.4.17
├── gmp
├── mpc
└── mpfr
opencoarrays will be installed in /home/bmaggard/oca/OpenCoarrays-1.9.2/build
Ready to rock and roll? (Y/n)
2017-10-16 06:18:24 UTC [ info] Invoking find_or_install mpich
install.sh: Checking whether mpich executable mpifort is in the PATH...yes.
Checking whether mpifort is in /home/bmaggard/oca/OpenCoarrays-1.9.2/prerequisites/installations/mpich/3.2...no.
install.sh: Checking whether mpifort in PATH wraps gfortran...
yes.
2017-10-16 06:18:34 UTC [ info] install.sh: Checking whether mpifort in PATH wraps gfortran version >= 6.1.0 and < 7.0.0 ...
yes.
install.sh: Using the mpifort found in the PATH.
install.sh: Updated dependency stack (top to bottom = left to right):
( none )
install.sh: Remaining mpich dependency stack (top to bottom = left to right):
( none )
2017-10-16 06:18:35 UTC [ info] Invoking find_or_install cmake
install.sh: Checking whether cmake is in the PATH...yes.
Checking whether cmake is in /home/bmaggard/oca/OpenCoarrays-1.9.2/prerequisites/installations/cmake/3.4.0...no.
install.sh: Checking whether cmake in PATH is version < 3.4.0...
no.
install.sh: Using the cmake found in the PATH.
install.sh: Updated dependency stack (top to bottom = left to right):
( none )
install.sh: Remaining cmake dependency stack (top to bottom = left to right):
( none )
~/oca/OpenCoarrays-1.9.2/prerequisites/builds/opencoarrays/1.9.2 ~/oca/OpenCoarrays-1.9.2/prerequisites
2017-10-16 06:18:48 UTC [ info] Configuring OpenCoarrays in /home/bmaggard/oca/OpenCoarrays-1.9.2/prerequisites/builds/opencoarrays/1.9.2 with the command:
2017-10-16 06:18:48 UTC [ info] CC="gcc" FC="gfortran" cmake "/home/bmaggard/oca/OpenCoarrays-1.9.2" -G "MSYS Makefiles" -DCMAKE_INSTALL_PREFIX="/home/bmaggard/oca/OpenCoarrays-1.9.2/build" -DMPIEXEC="/c/Intel-MPI/bin/mpirun" -DMPI_C_COMPILER="mpicc" -DMPI_C_LIBRARIES="/c/Intel-MPI/lib/libmpi.a" -DMPI_C_INCLUDE_PATH="/c/Intel-MPI/include" -DMPI_Fortran_COMPILER="mpifort" -DMPI_Fortran_LIBRARIES="/c/Intel-MPI/lib/libmpi.a" -DMPI_Fortran_INCLUDE_PATH="/c/Intel-MPI/include"
-- The C compiler identification is GNU 7.2.0
-- The Fortran compiler identification is GNU 7.2.0
-- Check for working C compiler: C:/msys64/mingw64/bin/gcc.exe
-- Check for working C compiler: C:/msys64/mingw64/bin/gcc.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working Fortran compiler: C:/msys64/mingw64/bin/gfortran.exe
-- Check for working Fortran compiler: C:/msys64/mingw64/bin/gfortran.exe -- works
-- Detecting Fortran compiler ABI info
-- Detecting Fortran compiler ABI info - done
-- Checking whether C:/msys64/mingw64/bin/gfortran.exe supports Fortran 90
-- Checking whether C:/msys64/mingw64/bin/gfortran.exe supports Fortran 90 -- yes
-- Building OpenCoarrays version: 1.9.2
-- Performing Test Check_Simple_Coarray_Fortran_Source_Compiles
-- Performing Test Check_Simple_Coarray_Fortran_Source_Compiles - Success
-- Found MPI_C: C:/Intel-MPI/lib/libmpi.a
-- Found MPI_Fortran: C:/Intel-MPI/lib/libmpi.a
-- MPI runtime and compile time environments appear to be consistent
-- Performing Test MPI_C_COMPILES
-- Performing Test MPI_C_COMPILES - Success
-- Performing Test MPI_Fortran_MODULE_COMPILES
-- Performing Test MPI_Fortran_MODULE_COMPILES - Failed
-- Performing Test MPI_Fortran_INCLUDE_COMPILES
-- Performing Test MPI_Fortran_INCLUDE_COMPILES - Success
CMake Warning at CMakeLists.txt:410 (message):
It appears that MPI was built with a different Fortran compiler. It is
possible that this may cause unpredictable behavior. The build will
continue using `mpif.h` BUT please report any suspicious behavior to the
OpenCoarrays developers.
-- Looking for alloca.h
-- Looking for alloca.h - not found
CMake Warning at src/mpi/CMakeLists.txt:33 (message):
Could not find <alloca.h>. Assuming functionality is provided elsewhere.
-- Looking for signal.h
-- Looking for signal.h - found
-- Looking for SIGKILL
-- Looking for SIGKILL - not found
-- Looking for SIGKILL
-- Looking for SIGKILL - found
-- Looking for include files mpi.h, mpi-ext.h
-- Looking for include files mpi.h, mpi-ext.h - not found
-- Looking for MPIX_ERR_PROC_FAILED
-- Looking for MPIX_ERR_PROC_FAILED - found
-- Looking for MPIX_ERR_REVOKED
-- Looking for MPIX_ERR_REVOKED - found
-- Looking for MPIX_Comm_failure_ack
-- Looking for MPIX_Comm_failure_ack - found
-- Looking for MPIX_Comm_failure_get_acked
-- Looking for MPIX_Comm_failure_get_acked - found
-- Looking for MPIX_Comm_shrink
-- Looking for MPIX_Comm_shrink - found
-- Looking for MPIX_Comm_agree
-- Looking for MPIX_Comm_agree - found
-- Looking for include file mpi.h
-- Looking for include file mpi.h - found
-- Looking for I_MPI_VERSION
-- Looking for I_MPI_VERSION - found
-- WIN32=1
-- Allocatable components of coarray derived types only supported in GFortran >= 7 with OpenCoarrays > 1.8.4
-- (but full support not anticipated until OpenCoarrays 2.0 release)
-- Configuring done
-- Generating done
-- Build files have been written to: C:/msys64/home/bmaggard/oca/OpenCoarrays-1.9.2/prerequisites/builds/opencoarrays/1.9.2
2017-10-16 06:19:31 UTC [ info] Building OpenCoarrays in /home/bmaggard/oca/OpenCoarrays-1.9.2/prerequisites/builds/opencoarrays/1.9.2 with the command make -j1
Scanning dependencies of target opencoarrays_mod
[ 1%] Building Fortran object src/mpi/CMakeFiles/opencoarrays_mod.dir/__/extensions/opencoarrays.F90.obj
[ 1%] Built target opencoarrays_mod
Scanning dependencies of target caf_mpi
[ 2%] Building C object src/mpi/CMakeFiles/caf_mpi.dir/mpi_caf.c.obj
[ 4%] Building C object src/mpi/CMakeFiles/caf_mpi.dir/__/common/caf_auxiliary.c.obj
[ 5%] Linking Fortran shared library ../../bin/OpenCoarrays-1.9.2-tests/libcaf_mpi.dll
Creating symlink include/opencoarrays.mod --> include/OpenCoarrays-1.9.2_GNU-7.2.0/opencoarrays.mod
failed to create symbolic link 'C:/msys64/home/bmaggard/oca/OpenCoarrays-1.9.2/prerequisites/builds/opencoarrays/1.9.2/include/opencoarrays.mod': Result too large
make[2]: *** [src/mpi/CMakeFiles/caf_mpi.dir/build.make:128: bin/OpenCoarrays-1.9.2-tests/libcaf_mpi.dll] Error 1
make[2]: *** Deleting file 'bin/OpenCoarrays-1.9.2-tests/libcaf_mpi.dll'
make[1]: *** [CMakeFiles/Makefile2:176: src/mpi/CMakeFiles/caf_mpi.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
2017-10-16 06:19:34 UTC [ info] Cleaning up. DoneNext, I'll take a look at the symlink creation error, and let you know if I make any additional progress.
zbeekman
rouson
Defect/Bug Report
Observed Behavior
Line 52 of src/mpi/CMakeLists.txt: Unless the 3rd argument of
CHECK_SYMBOL_EXISTSis a new, unused variable, the function does not seem to be called (or perhaps is called, but does not produce any output or change the value of the 3rd argument).Expected Behavior
Verify SIGKILL is defined, with -D_POSIX required for GCC, MinGW-w64 on Windows (including MSYS).
Steps to Reproduce
A small test example:
$ rm -rf build $ cat src/CMakeLists.txt cmake_minimum_required(VERSION 3.9 FATAL_ERROR) project(sigkill NONE) enable_language(C) include(CheckIncludeFile) CHECK_INCLUDE_FILE("signal.h" HAVE_SIGNAL_H)
add_executable(h h.c)
include(CheckSymbolExists) CHECK_SYMBOL_EXISTS(SIGINT "signal.h" HAVE_SIGINT) CHECK_SYMBOL_EXISTS(SIGKILL "signal.h" HAVE_SIGKILL) CHECK_SYMBOL_EXISTS(SIGILL "signal.h" HAVE_SIGILL) if(NOT HAVE_SIGKILL) message("Trying -D_POSIX") list( APPEND CMAKE_REQUIRED_DEFINITIONS -D_POSIX) CHECK_SYMBOL_EXISTS(SIGKILL "signal.h" HAVE_SIGKILL_NEW) endif()
$ cmake -Bbuild -Hsrc -G "MSYS Makefiles" -- The C compiler identification is GNU 7.2.0 -- Check for working C compiler: C:/msys64/mingw64/bin/gcc.exe -- Check for working C compiler: C:/msys64/mingw64/bin/gcc.exe -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Detecting C compile features -- Detecting C compile features - done -- Looking for signal.h -- Looking for signal.h - found -- Looking for SIGINT -- Looking for SIGINT - found -- Looking for SIGKILL -- Looking for SIGKILL - not found -- Looking for SIGILL -- Looking for SIGILL - found Trying -D_POSIX -- Looking for SIGKILL -- Looking for SIGKILL - found -- Configuring done -- Generating done -- Build files have been written to: C:/msys64/home/bmaggard/temp/sigkill/build
$ cmake -Bbuild -Hsrc -G "MSYS Makefiles" -- The C compiler identification is GNU 7.2.0 -- Check for working C compiler: C:/msys64/mingw64/bin/gcc.exe -- Check for working C compiler: C:/msys64/mingw64/bin/gcc.exe -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Detecting C compile features -- Detecting C compile features - done -- Looking for signal.h -- Looking for signal.h - found -- Looking for SIGINT -- Looking for SIGINT - found -- Looking for SIGKILL -- Looking for SIGKILL - not found -- Looking for SIGILL -- Looking for SIGILL - found Trying -D_POSIX -- Configuring done -- Generating done -- Build files have been written to: C:/msys64/home/bmaggard/temp/sigkill/build