sourceryinstitute / OpenCoarrays

A parallel application binary interface for Fortran 2018 compilers.
http://www.opencoarrays.org
BSD 3-Clause "New" or "Revised" License
243 stars 58 forks source link

Add random_init() and testcase. #734

Closed vehre closed 2 years ago

vehre commented 3 years ago
coverage on master
Codecov branch

Summary of changes

Add handling for random_init() for mpi_caf.

Rationale for changes

The api in gfortran has changed and this patch applies this change for OpenCoarrays by implementing random_init and testcases.

Additional info and certifications

This pull request (PR) is a:

I certify that

Code coverage data

coverage on master

rouson commented 3 years ago

@vehre the GitHub interface on this PR contained a notification that the branch was not up-to-date with main so I clicked the button to update the branch. This relaunched the CI tests, resulting in a failure on building the new unit test. Please take a look at this and fix it if possible.

vehre commented 3 years ago

Sorry, made the beginner's mistake to not add the testcase's source code to the commit. This is fixed now. Because the gfortran side is not yet on master (I am working on it!), the testcase is not run. For this a recent gfortran 12 is needed.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

rouson commented 3 years ago

@vehre for some reason, the CI check doesn't show that you signed the Contributor License Agreement (CLA) even though surely you did years ago. Could you please try signing it again so that this can be merged? Is it ready to be merged?

vehre commented 3 years ago

Er, well, how do I sign this license again? I see no link that I can click on.

gcc-11 now has the patch for random_init, so this is ready to be merged here in OpenCoarrays, too.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.