sourceryinstitute / OpenCoarrays

A parallel application binary interface for Fortran 2018 compilers.
http://www.opencoarrays.org
BSD 3-Clause "New" or "Revised" License
243 stars 58 forks source link

Issue 739 fix seg fault #741

Closed vehre closed 2 years ago

vehre commented 2 years ago
coverage on master
Codecov branch

Summary of changes

Fix a crash when indexing into static array.

Rationale for changes

Prevent a segfault.

Additional info and certifications

This pull request (PR) is a:

I certify that

Code coverage data

coverage on master

rouson commented 2 years ago

@everythingfunctional could you take a look at what's happening with the "pullapprove Failed to load extends URL (HTTP 404)" message above?

everythingfunctional commented 2 years ago

I've not seen the WIP or pullapprove checks before, and I don't see anything in the code in the repository that would indicate enabling them. Is there some GitHub setting/new feature that got turned on?

rouson commented 2 years ago

@everythingfunctional thanks for checking. I found an email indicating that this is third-party app. I don't recall enabling, but I think I have now disabled it. I also replied to the email to ask how to remove it from this PR. I also tried merging into main at the command line, but my subsequent push was rejected.