Defect: Test cases use pre-F2018 co_reduce()-parameter operator, which is renamed in F2018 to operation

vehre commented 2 years ago

In gcc>=12 the Fortran Standard 2018's co_reduce(... operation=...) is implement. Code using pre-2018 Fortran (and still using operator=...) will stop compiling.

Please note we will close your issue without comment if you delete, do not read or do not fill out the issue checklist below and provide ALL the requested information.

[x] I am reporting a bug others will be able to reproduce and not asking a question or requesting a new feature.

System information including:

OpenCoarrays Version:
Fortran Compiler:
C compiler used for building lib:
Installation method:
All flags & options passed to the installer
Output of uname -a:
MPI library being used:
Machine architecture and number of physical cores:
Version of CMake:

To help us debug your issue please explain:

What you were trying to do (and why)

What happened (include command output, screenshots, logs, etc.)

What you expected to happen

Step-by-step reproduction instructions to reproduce the error/bug

Compile testsuite with gcc>=12.

vehre commented 2 years ago

Fix is available at: https://github.com/sourceryinstitute/OpenCoarrays/tree/issue-745-rename-co_reduce-operator-for-F2018

The fix uses the pre-processor to use the different identifiers depending on the gcc-version used. Therefore the files had to renamed to *.F90, i.e. with a capital F which by convention enables preprocessor-processing.

GitHub
GitHub - sourceryinstitute/OpenCoarrays at issue-745-rename-co_reduce-operator-for-F2018
A parallel application binary interface for Fortran 2018 compilers. - GitHub - sourceryinstitute/OpenCoarrays at issue-745-rename-co_reduce-operator-for-F2018