Name of ZIP - Githubissues

sourcetoad / aws-codedeploy-action

AWS CodeDeploy via GitHub Actions

MIT License

35 stars 14 forks source link

Name of ZIP #1

Closed iBotPeaches closed 3 years ago

iBotPeaches commented 3 years ago

echo $GITHUB_RUN_ID-$GITHUB_SHA.zip // 474524530-36d2fd3092a9883df9a2f0ce290f0944534a793f.zip

Need to compare to what our existing thing (Jenkins) builds to see if thats close enough or anyone uses the name of the zip file.

iBotPeaches commented 3 years ago

@jweberst as long as the first number just increments does that suffice for the default sort order on S3? I can't find any other variable that is like just a build # that exists on Jenkins - https://docs.github.com/en/free-pro-team@latest/actions/reference/environment-variables

Run ID is closest, but the numbers are so much higher than 1,2,3,4,5

jweberst commented 3 years ago

I think that's fine. I don't even thing it matters at all, because we can sort by date. However, since I assume we might build multiple times, this makes sense.

iBotPeaches commented 3 years ago

Sounds good. It is now set with that.