Closed Vacoris closed 1 year ago
So I wonder if we need to wrap all calls to AWS. I liked previously when I dev/null`d the output from API, but then you don't see the clear and obvious permission error.
So I wonder if we need to wrap all calls to AWS. I liked previously when I dev/null`d the output from API, but then you don't see the clear and obvious permission error.
We might have to since the user who posted the issue looks to have made a user with specific permissions. So I'd assume we'd need to consider all the permissions that we are using with the aws calls. Just the codedeploy alone I see 3 more permissions to wrap. The get-deployment, create-deployment, and register-application-revision.
We'd then need to check also the aws s3 and s3api command as well I would think.
Error handling brought up from Issue #67 reported by user.
fixes https://github.com/sourcetoad/aws-codedeploy-action/issues/67
Checks for non-success condition and if unsuccessful then bails out.