search

sourcetoad / aws-codedeploy-action

AWS CodeDeploy via GitHub Actions
MIT License
35 stars 13 forks source link

fix: handle missing list-deployments error #68

Closed Vacoris closed 1 year ago

Vacoris commented 1 year ago

Error handling brought up from Issue #67 reported by user.

fixes https://github.com/sourcetoad/aws-codedeploy-action/issues/67

Checks for non-success condition and if unsuccessful then bails out.

iBotPeaches commented 1 year ago

So I wonder if we need to wrap all calls to AWS. I liked previously when I dev/null`d the output from API, but then you don't see the clear and obvious permission error.

Vacoris commented 1 year ago

So I wonder if we need to wrap all calls to AWS. I liked previously when I dev/null`d the output from API, but then you don't see the clear and obvious permission error.

We might have to since the user who posted the issue looks to have made a user with specific permissions. So I'd assume we'd need to consider all the permissions that we are using with the aws calls. Just the codedeploy alone I see 3 more permissions to wrap. The get-deployment, create-deployment, and register-application-revision.

https://docs.aws.amazon.com/codedeploy/latest/userguide/auth-and-access-control-permissions-reference.html

Vacoris commented 1 year ago

We'd then need to check also the aws s3 and s3api command as well I would think.