search

sourcey / libsourcey

C++14 evented IO libraries for high performance networking and media based applications
https://sourcey.com/libsourcey
GNU Lesser General Public License v2.1
1.32k stars 349 forks source link

FindOpenCV.cmake semi-broken #18

Closed dshadowwolf closed 8 years ago

dshadowwolf commented 10 years ago

The code has a few bugs, one in the handling of a passed-in 'OpenCV_INCLUDE_DIR' - which is required to include the 'opencv2' part of the path and the version detection, another with part of the auto-detection of the include path being commented out and a third with the detection of the libraries, where it doesn't attempt to look in the correct places for libraries on a distribution setup to be (primarily) 64bit but with some 32bit libraries installed for legacy and/or applications which are not provided as 64bit.

I have a patch which fixes 2 of the 3 issues noted that I can provide if necessary. The first issue is one that I'm not certain how to properly fix, as I don't use CMake enough to be fully familiar and comfortable with the language, but the other two have been fixed.

auscaster commented 9 years ago

@dshadowwolf please add the updated file in a pull request and I will review your changes.

dshadowwolf commented 9 years ago

Sorry about that - I don't have this forked on github, so... here is a patch from git diff.

Okay, can't just post a patch - let me just go hit the 'fork' button and push my patched version to it

auscaster commented 8 years ago

Thanks, closing this down now.