search

sourcey / libsourcey

C++14 evented IO libraries for high performance networking and media based applications
https://sourcey.com/libsourcey
GNU Lesser General Public License v2.1
1.31k stars 347 forks source link

Update Dockerfile for FFmpeg and introduce support for x86 #253

Closed michaelfig closed 5 years ago

michaelfig commented 5 years ago

Hi!

I'm getting back into LibSourcey as finally my WebRTC application (using https://mediasoup.org on the server side) is gaining some traction. I'd like to stream to a Mediasoup room from an Linux x86-based device.

To do this, I needed to install FFmpeg, and noticed that Ubuntu bionic (18.04) has all the libraries I need. I updated the Dockerfile to use bionic and FFmpeg, which I think should be nice for other people, too and is pushed to https://hub.docker.com/r/michaelfig/libsourcey/

My x86 Docker support is hampered by no linux-x86 build corresponding to the webrtc-precompiled-builds used by x64 in the Dockerfile. LibSourcey v1.1.4 appears not to compile with the latest x86 webrtc-precompiled-build. Help with that would be appreciated.

Have fun! Michael.

michaelfig commented 5 years ago

BTW, I changed the Dockerfile to use a COPY . libsourcey instead of the git clone, since I was testing. If you want to put it back, Kam, feel free!

michaelfig commented 5 years ago

Hi Kam,

Sorry, but this PR is somewhat of a disorganised mess. I didn't end up needing x86 support, and since I had made the PR against my forked master branch, it just includes a bunch of miscellany. LMK if you would like it split up into different branches, by topic if you'd like.

Things are working great for my app, anyway. 👍

Thanks, Michael.

auscaster commented 5 years ago

Glad to hear things are going well for you, you've certainly been busy!

You appear to be in the middle some pretty heavy dev so I'll hold off on merging any code. When you feel you are ready for me to check everything just drop me a line.

michaelfig commented 5 years ago

This PR has been superceded by #257.

michaelfig commented 5 years ago

I've opened new PRs that should be ready for merging. I'll hold off merging anything else until I can make things more general.