auscaster
commented
5 years ago Hey there, yes please do :) Any work you have done work will certainly save some time and can always be double checked
On Tue, 21 May 2019 at 12:15, blackforest-tom notifications@github.com wrote:
Hey,
just building with ffmpeg, downloaded from their original website. It breaks the build, since in newer ffmpeg versions, the libav constants have been prefixed by "AV_". I wrote a macro, checking for ffmpeg version, and edited audioencoder.cpp and videoencoder.cpp to use the appropriate constants. Unfortunately, i cannot test this with older ffmpeg versions, nor verify that the version i am splitting the names for is the perfectly right one (i got the version number from other projects, who had to do similar). Do you want me to issue a pull-request, although i cannot verify 100% if all was done correctly?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/sourcey/libsourcey/issues/266?email_source=notifications&email_token=AAAYUDELKHPA4F2A4OTKXWTPWPDS3A5CNFSM4HOJPFPKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GU5SQDQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAYUDHFMTC26R4GPXFHW53PWPDS3ANCNFSM4HOJPFPA .
mgyong
blackforest-tom
Hey,
just building with ffmpeg, downloaded from their original website. It breaks the build, since in newer ffmpeg versions, the libav constants have been prefixed by "AV_". I wrote a macro, checking for ffmpeg version, and edited audioencoder.cpp and videoencoder.cpp to use the appropriate constants. Unfortunately, i cannot test this with older ffmpeg versions, nor verify that the version i am splitting the names for is the perfectly right one (i got the version number from other projects, who had to do similar). Do you want me to issue a pull-request, although i cannot verify 100% if all was done correctly?