search

sourcey / libsourcey

C++14 evented IO libraries for high performance networking and media based applications
https://sourcey.com/libsourcey
GNU Lesser General Public License v2.1
1.31k stars 344 forks source link

LibSourcey does not support modern version of WebRTC, because cricket::VideoCapturer was removed from WebRTC #284

Open kapulkin opened 4 years ago

kapulkin commented 4 years ago

Building libSourcey with last version of WebRTC on 23.04.2020 leads to errors. Some errors could be simply fixed:

include "rtc_base/criticalsection.h" -> #include "rtc_base/critical_section.h"

include "rtc_base/scoped_ref_ptr.h" -> #include "base/memory/scoped_refptr.h"

But there is more complex: src/webrtc/.../videopacketsource.h relies on cricket::VideoCapturer, which was deprecated and lately removed from WebRTC (see WebRTC developers discussion there: https://bugs.chromium.org/p/webrtc/issues/detail?id=6353)

The videopacketsource.h file references on file, with was removed: #include "media/base/videocapturer.h" and class definition inside extend from removed class: class VideoPacketSource : public cricket::VideoCapturer

Please, rewrite the code with new video classes according to the samples mentioned in the discussion above.

kapulkin commented 4 years ago

There is a commit, were the cricket library was removed: https://chromium.googlesource.com/external/webrtc/+/45c8b8940042bd2574c39920804ade8343cefdba

auscaster commented 4 years ago

Hi!

Thanks very much for the PR, lets continue the discussion over there.