Closed Jared314 closed 8 years ago
This is due to the fact that uv module is a header only module. I was able to overcome this by checking if(NOT lib_srcs STREQUAL "")
and only doing add_library
in case its true. This is all happening in LibSourceyModule.cmake.
Thanks for clearing up this outstanding OSX issue. Can you please make a PR for these fixes when you are able?
On 27 November 2015 at 07:47, Zelim Damian notifications@github.com wrote:
This is due to the fact that uv module is a header only module. I was able to overcome this by checking if(NOT lib_srcs STREQUAL "") and only doing add_library in case its true
— Reply to this email directly or view it on GitHub https://github.com/sourcey/libsourcey/issues/66#issuecomment-159997139.
I'm sorry, but I'm not sure if my changes are clean enough for a PR. Especially since I have not tested on non OSX machines. I had to change a lot of CMake to make it compile, but then I still got run-time assertions. I will try to clean up my changes for this particular issue and do a PR though.
@Jared314, here a version that compiles on OSX: https://github.com/ZelimDamian/libsourcey/commit/48e00c50b34980a013a3f8fc6763075d7b2abbfb
I'm not PRring just yet as I have not tested on a Windows machine
@ZelimDamian Thank you. I will give it a shot and update this issue if it works.
Please sync with the latest source, as many linker issues have been fixed.
I'm attempting to use libsourcey in a C++ library, using CMake and Make to build libsourcey as an external project. Unfortunately, OSX's version of
ar
does not allow libraries that contain only headers, likelibscy_uv
.Is there a way to prevent it from linking against
libscv_uv
? I'm fairly new to CMake, so I might be building it incorrectly.CMakeLists.txt:
Build Error: