sourcey / spectacle

Beautiful static documentation generator for OpenAPI/Swagger 2.0
https://sourcey.com/spectacle
Other
1.28k stars 337 forks source link

Breaking change in dependency Cheerio v1.0.0-rc.9 #223

Closed jordanmaguire closed 3 years ago

jordanmaguire commented 3 years ago

One of the dependencies of spectacle is Cheerio

The latest RC has a breaking change.

https://github.com/cheeriojs/cheerio/releases/tag/v1.0.0-rc.9

I suppose you might like to decide whether you lock the dependency down to an old version or lock it down to a newer version and change the syntax to fix the breaking change.

In the interim, I'm working around this by locking the dependency myself with:

  "resolutions": {
    "spectacle-docs/cheerio": "1.0.0-rc.6"
  },
tommyschnabel commented 3 years ago

+1

jordanmaguire commented 3 years ago

Looks to be resolved by #224

yarn add 'spectacle-docs@https://github.com/sourcey/spectacle#3257da500b8a2483b6ad3356e50fe00b65bb6a6f' until there's a release