Update plugin to also show partial matches

sourcifyeth / remix-sourcify

Remix plugin for source verify project

21 stars 12 forks source link

Update plugin to also show partial matches #27

Closed edisinovcic closed 2 years ago

edisinovcic commented 4 years ago

Contract fetcher needs to be updated to also show partial matches.

DeFiYaco commented 4 years ago

Contract verifier should also show partial match and redirect to the https://contractrepo.komputing.org/partial_matches/:id/:address when plugin receives "status":"partial". Right now it navigates to https://contractrepo.komputing.org/contracts/:id/:address which results in error 404.

edisinovcic commented 3 years ago

@FabijanC please confirm this is now working.

FabijanC commented 3 years ago

@edisinovcic There is a pending pull request (on the Sourcify GitHub repo) that introduces two new server endpoints that return partial if full is not available: https://github.com/ethereum/sourcify/pull/325

ogwurujohnson commented 2 years ago

@kuzdogan i think we can close this right? Since this has been implemented

kuzdogan commented 2 years ago

Yes sure. Duplicate of https://github.com/ethereum/sourcify/issues/614