probable performance issue when autocompile is on

sourcifyeth / remix-sourcify

Remix plugin for source verify project

21 stars 12 forks source link

probable performance issue when autocompile is on #39

Closed yann300 closed 3 years ago

yann300 commented 4 years ago

When autocompile is on:

activate sourcify
keep pressing space in the editor for triggering a compilation
after some time the browser become unresponsive.

This happen with Firefox

edisinovcic commented 4 years ago

It can be reproduced. As you mentioned probable reason is that sourcify is listening on compilationFinished and it freezes the browser as compilationFinished is triggered every time when source code gets compiled.

Open for proposals for solution of this.

yann300 commented 3 years ago

This is still happening, for reproducing:

activate the sourcify plugin
compile any contract (ctrl-s)
recompile it several times (ctrl-s)
the browser starts to freeze

Part of the issue is that the VerifyContract https://github.com/sourcifyeth/remix-sourcify/blob/1879b24a76be3e9bfd4034f5e402f2e3908e745b/src/components/verify-contract/VerifyContract.tsx#L62 is called after each compilationFinished event, which then seems to re-register using remixClient.listenOnCompilationFinishedEvent

edisinovcic commented 3 years ago

This should be fixed now. Closing.