Update network dropdown label from name to title property

sourcifyeth / remix-sourcify

Remix plugin for source verify project

21 stars 12 forks source link

Update network dropdown label from name to title property #70

Closed oceans404 closed 2 years ago

oceans404 commented 2 years ago

Before this change, the remix network dropdown label displays the name field rather than title. This makes it difficult to discover testnets if searching by the mainnet.

Expected behavior: Polygon Mumbai is listed underneath Polygon Mainnet.
Problem: "Mumbai" isn't listed underneath Polygon Mainnet because it is named "Mumbai" but titled "Polygon Testnet Mumbai.

https://chainid.network/chains.json

{ "name": "Mumbai", "title": "Polygon Testnet Mumbai", .... }

marcocastignoli commented 2 years ago

Hey @oceans404, I pushed this commit https://github.com/ethereum/sourcify/commit/168d6eae8c6bb928e0cb25bf3b6c5e6cec251c81 in the sourcify main repo, once it is merged in master I will merge this PR. Thanks :slightly_smiling_face:

oceans404 commented 2 years ago

awesome, thanks @marcocastignoli