search

sourmash-bio / sourmash

Quickly search, compare, and analyze genomic and metagenomic data sets.
http://sourmash.readthedocs.io/en/latest/
Other
473 stars 80 forks source link

separate out load_signatures code to distinguish loading-from-file and parsing-from-string #1060

Open ctb opened 4 years ago

ctb commented 4 years ago

per https://github.com/dib-lab/sourmash/issues/875#issuecomment-583783495

this would be an API change to a frequently used function, so gotta be careful and do this for a major version change.

ctb commented 3 years ago

punt to 5.0, I think.

ctb commented 5 months ago

pretty sure this bug https://github.com/sourmash-bio/sourmash/issues/2945 is caused by the checks put in place to support loading from string.

ref:

ctb commented 5 months ago

this would be an API change to a frequently used function, so gotta be careful and do this for a major version change.

3161 completes the task of making this a not-public function (deprecated for v5.0, removed from most internal use, and renamed to load_signatures_from_json). So we'll be in good shape for changing the behavior for the future.